[3.13] gh-124096: Enable REPL virtual terminal support on Windows (GH-124119) #133457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honGH-124119) To support virtual terminal mode in Windows PYREPL, we need a scanner to read over the supported escaped VT sequences. Windows REPL input was using virtual key mode, which does not support terminal escape sequences. This patch calls `SetConsoleMode` properly when initializing and send sequences to enable bracketed-paste modes to support verbatim copy-and-paste. (cherry picked from commit a65366e) Co-authored-by: Y5 <[email protected]> Signed-off-by: y5c4l3 <[email protected]> Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Dustin L. Howett <[email protected]> Co-authored-by: wheeheee <[email protected]>
|
All commit authors signed the Contributor License Agreement. |
|
@y5c4l3 can you click the CLA button again, please? The CLA bot wants you to connect this noreply GitHub email with a real email for our database. I landed the PR in the mean time in the interest of time, but we'd still like you to click through the CLA, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support virtual terminal mode in Windows PYREPL, we need a scanner
to read over the supported escaped VT sequences.
Windows REPL input was using virtual key mode, which does not support
terminal escape sequences. This patch calls
SetConsoleModeproperlywhen initializing and send sequences to enable bracketed-paste modes
to support verbatim copy-and-paste.
(cherry picked from commit a65366e)
Co-authored-by: Y5 [email protected]
Signed-off-by: y5c4l3 [email protected]
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Pablo Galindo Salgado [email protected]
Co-authored-by: Dustin L. Howett [email protected]
Co-authored-by: wheeheee [email protected]