Skip to content

gh-133810: remove http.server.CGIHTTPRequestHandler and --cgi flag #133811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 17, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 10, 2025

@picnixz
Copy link
Member Author

picnixz commented May 10, 2025

Free-threaded failure is known: #132983 (comment).

@picnixz picnixz requested a review from hugovk May 16, 2025 11:01
@picnixz picnixz requested a review from hugovk May 16, 2025 15:28
@hugovk
Copy link
Member

hugovk commented May 16, 2025

Still some suggestions that GitHub is hiding about not bumping the __version__, and some unused imports in Lib/http/server.py.

picnixz and others added 2 commits May 16, 2025 17:31
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice cleanup! +28 −755

@picnixz
Copy link
Member Author

picnixz commented May 16, 2025

Thanks for the review! Sorry for this long back and forth but I was using GH UI :')

@hugovk
Copy link
Member

hugovk commented May 16, 2025

It's all good! 🚀

@picnixz picnixz self-assigned this May 16, 2025
@picnixz picnixz merged commit faac627 into python:main May 17, 2025
43 checks passed
@picnixz picnixz deleted the cleanup/315/remove-cgi-handler-133810 branch May 17, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants