-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-36953: Delay removal of ABCs from collections. #13409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36953: Delay removal of ABCs from collections. #13409
Conversation
Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9? |
The policy is AFAICT removal n+2 after deprecation. We do have to remove at some point no? And adding the version number for removal make it easy to search for all that was marked for removal, as well as give expectation to readers. In any case here we are just discussing bumping the version number, which should be less controversial than discussing if their should be one. |
I think this deserves a |
Why not... done. |
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive tdeprecated-removed.
Co-Authored-By: Xtreak <[email protected]>
0ca83e5
to
c34186d
Compare
Title and commits were mentioning wrong issues; rebased/edited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates, LGTM!
This typo was introduced in GH-13409 when changing the message text.
This typo was introduced in pythonGH-13409 when changing the message text. (cherry picked from commit c4106af) Co-authored-by: Florian Bruhin <[email protected]>
This typo was introduced in GH-13409 when changing the message text. (cherry picked from commit c4106af) Co-authored-by: Florian Bruhin <[email protected]>
This typo was introduced in pythonGH-13409 when changing the message text.
Thanks @Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-16675 is a backport of this pull request to the 3.7 branch. |
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <[email protected]>
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <[email protected]>
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953 (cherry picked from commit eea47e0) Co-authored-by: Matthias Bussonnier <[email protected]>
Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953
This typo was introduced in pythonGH-13409 when changing the message text.
This typo was introduced in pythonGH-13409 when changing the message text.
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.
https://bugs.python.org/issue36953