Skip to content

gh-127146: Emscripten: more regular stack overflow skips #136708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

gh-127146: Emscripten: more regular stack overflow skips #136708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8642a6c
gh-127146: Emscripten: use skip_emscripten_stack_overflow instead of …
hoodmane Jul 16, 2025
e74f523
Fix
hoodmane Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ def skip_android_selinux(name):
is_wasi = sys.platform == "wasi"

def skip_emscripten_stack_overflow():
return unittest.skipIf(is_emscripten, "Exhausts limited stack on Emscripten")
return unittest.skipIf(is_emscripten, "Exhausts stack on Emscripten")

def skip_wasi_stack_overflow():
return unittest.skipIf(is_wasi, "Exhausts stack on WASI")
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3942,7 +3942,7 @@ def __del__(self):
# it as a leak.
del C.__del__

@unittest.skipIf(support.is_emscripten, "Seems to works in Pyodide?")
@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
def test_slots_trash(self):
# Testing slot trash...
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_xml_etree_c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def test_del_attribute(self):
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})

@support.skip_wasi_stack_overflow()
@unittest.skipIf(support.is_emscripten, "segfaults")
@support.skip_emscripten_stack_overflow()
def test_trashcan(self):
# If this test fails, it will most likely die via segfault.
e = root = cET.Element('root')
Expand Down
Loading