Skip to content

gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc #136740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged

gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc #136740

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
595781e
gh-127146: Emscripten: Set umask to zero in python.sh
hoodmane Jul 17, 2025
89144bf
Merge branch 'main' into emscripten-set-umask-zero
hoodmane Jul 17, 2025
643e889
More specific fix
hoodmane Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_pydoc/test_pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,11 @@ def test_apropos_with_unreadable_dir(self):
@os_helper.skip_unless_working_chmod
def test_apropos_empty_doc(self):
pkgdir = os.path.join(TESTFN, 'walkpkg')
if support.is_emscripten:
# Emscripten's readdir implementation is buggy on directories
# with read permission but no execute permission.
old_umask = os.umask(0)
self.addCleanup(os.umask, old_umask)
os.mkdir(pkgdir)
self.addCleanup(rmtree, pkgdir)
init_path = os.path.join(pkgdir, '__init__.py')
Expand Down
Loading