Skip to content

[3.7] bpo-21315: Fix parsing of encoded words with missing leading ws. (GH-13425) #13846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 5, 2019

  • bpo-21315: Fix parsing of encoded words with missing leading ws.

Because of missing leading whitespace, encoded word would get parsed as
unstructured token. This patch fixes that by looking for encoded words when
splitting tokens with whitespace.

Missing trailing whitespace around encoded word now register a defect
instead.

Original patch suggestion by David R. Murray on bpo-21315.
(cherry picked from commit 66c4f3f)

Co-authored-by: Abhilash Raj [email protected]

https://bugs.python.org/issue21315

…honGH-13425)

* bpo-21315: Fix parsing of encoded words with missing leading ws.

Because of missing leading whitespace, encoded word would get parsed as
unstructured token. This patch fixes that by looking for encoded words when
splitting tokens with whitespace.

Missing trailing whitespace around encoded word now register a defect
instead.

Original patch suggestion by David R. Murray on bpo-21315.
(cherry picked from commit 66c4f3f)

Co-authored-by: Abhilash Raj <[email protected]>
@miss-islington
Copy link
Contributor Author

@maxking and @warsaw: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@maxking and @warsaw: Status check is done, and it's a success ✅ .

@warsaw warsaw merged commit dc20fc4 into python:3.7 Jun 6, 2019
@bedevere-bot
Copy link

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-66c4f3f-3.7 branch June 6, 2019 17:08
epicfaace pushed a commit to epicfaace/cpython that referenced this pull request Sep 3, 2019
pythonGH-13425) (pythonGH-13846)

* bpo-21315: Fix parsing of encoded words with missing leading ws.

Because of missing leading whitespace, encoded word would get parsed as
unstructured token. This patch fixes that by looking for encoded words when
splitting tokens with whitespace.

Missing trailing whitespace around encoded word now register a defect
instead.

Original patch suggestion by David R. Murray on bpo-21315.
(cherry picked from commit 66c4f3f)

Co-authored-by: Abhilash Raj <[email protected]>
(cherry picked from commit dc20fc4)

Co-authored-by: Miss Islington (bot) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants