Skip to content

bpo-12217 Added linking of pdb, faulthandler and traceback documentation #14754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jdkandersson
Copy link
Contributor

@jdkandersson jdkandersson commented Jul 13, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CLA is approved (it's already been submitted), this is ready to merge.

@@ -170,3 +173,8 @@ handler:
File "<stdin>", line 1 in <module>
Segmentation fault


.. seealso::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to put it at the top, rather than at the end? Same remark for pdb.rst.

@matrixise
Copy link
Member

@jdkandersson We can't use your PR because the bot does not want to accept your PR. A problem with the user of your commits, this user has not signed the CLA (david-andersson) but the CLA is signed for @jdkandersson. Please could you close this PR and recreate a new PR where you use the right github account (jdkandersson) and not (david-andersson) for your commits and PR.

Thank you

@csabella
Copy link
Contributor

@jdkandersson, please address the prior comments regarding the CLA. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants