Skip to content

bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) #15173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

smokephil
Copy link
Contributor

@smokephil smokephil commented Aug 8, 2019

bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)

https://bugs.python.org/issue25810

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for the contribution!

Based on the comment from R. David Murray:

I think we are moving toward using (and documenting in the main docs) the / notation. Especially since it shows up in the inspect module as well as the docstring help.

as well as the rest of the discussion on the issue, I think it would be more appropriate to use the / notation:

@gpshead gpshead self-assigned this Sep 10, 2019
@gpshead gpshead changed the title bpo-25810: fix documentation for eval() call bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) Sep 11, 2019
@gpshead gpshead merged commit 7a0023e into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

Thanks @smokephil for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@bedevere-bot
Copy link

GH-15910 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@bedevere-bot
Copy link

GH-15911 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
miss-islington added a commit that referenced this pull request Sep 11, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants