bpo-38385: Fix iterator/iterable terminology in statistics docs #17111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
added
docs
lebigot
reviewed
Nov 12, 2019
There was a problem hiding this comment.
Thanks.
Do we still need to keep the "sequence or" (iterable) part? "data can be any iterable" would be enough and I prefer it:
- It's short so the doc reads a bit faster.
- It avoids being surprised and a bit puzzled (why mention sequence as an apparent alternative to an iterable?).
Sequence could still be mentioned as an example of iterable, if needed.
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-17113 is a backport of this pull request to the 3.8 branch. |
rhettinger
added a commit
that referenced
this pull request
Nov 12, 2019
…7111) (GH-17113) (cherry picked from commit 733b9a3) Co-authored-by: Raymond Hettinger <[email protected]>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by Eric O. LEBIGOT
https://bugs.python.org/issue38385