bpo-39890: Don't mangle the AST when compiling starred assignments #18833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Mar 8, 2020
| @@ -0,0 +1 @@ | |||
| Don't mutate the AST when compiling starred assignments. | |||
There was a problem hiding this comment.
This is an internal change without user impact so we don't need NEWS entry for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
assignment_helperis the only place where we actually change the semantic meaning of the AST during compilation (a starred name is changed to a regular name as a shortcut).This probably isn't a great idea, and it would bite us later if we started making multiple passes or reusing the AST or something.
https://bugs.python.org/issue39890