Skip to content

bpo-37973: Improve the docstrings of sys.float_info #19218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

bpo-37973: Improve the docstrings of sys.float_info #19218

merged 1 commit into from
May 24, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Mar 29, 2020 •
edited by bedevere-bot
Loading

@ZackerySpytz
Copy link
Contributor Author

I don't think this needs a news entry.

@ammaraskar
Copy link
Member

Maybe the definition of DBL_MANT_DIG should be pulled in as well?

@csabella csabella requested a review from mdickinson May 23, 2020 20:07
mdickinson
mdickinson approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, as far as they go.

@mdickinson
Copy link
Member

mdickinson commented May 24, 2020 •
edited
Loading

Merging. There are other possible improvements here, but they can come in later PRs, and shouldn't block the merge of this one.

@mdickinson mdickinson merged commit fdc5a94 into python:master May 24, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@ZackerySpytz @arturoescaip
bpo-37973: Improve the docstrings of sys.float_info (pythonGH-19218)
c7e9074 
Taken from https://docs.python.org/3/library/sys.html#sys.float_info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees

@mdickinson mdickinson

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @ammaraskar @mdickinson @the-knights-who-say-ni @bedevere-bot