Skip to content

bpo-40690: Check that testcase.__module__ != 'unittest.case' #20237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

abetkin
Copy link

@abetkin abetkin commented May 19, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@abetkin

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

@abetkin, please sign the CLA as per the previous comment. Thanks!

@remilapeyre
Copy link
Contributor

Hi @abetkin, thanks for the PR! Like I said on BPO, this only fix one loader, the other have the same issue. To be accepted the change will need some tests and a NEWS entry, you can add one by using https://blurb-it.herokuapp.com/.

@csabella
Copy link
Contributor

@abetkin, as mentioned before, we can't accept a PR without a signed CLA. If you are unable to sign the CLA, then this PR will be closed.

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jul 20, 2020
@csabella
Copy link
Contributor

I'm going to close this as the CLA has not been signed. Once the CLA is signed, it can be reopened. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants