bpo-40217: Make heap types always visit Py_TYPE(self) from tp_traverse #20433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r PyType_FromSpec types (pythonGH-19414)" This reverts commit 0169d30.
If the base is a heap type, the responsibility to visit Py_TYPE(self) is delegated to the base's tp_traverse.
I think |
|
I don't mind, please go ahead! |
|
Actually, I can even do it myself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of @pablogsal's #20264, see discussion there.
See the proposed docs for what is changing.
There is a reference leak in test_interpreters that I haven't yet been able to track down.
https://bugs.python.org/issue40217