Skip to content

bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer() #20685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2020
Merged

bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer() #20685

merged 1 commit into from
Jun 7, 2020

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Jun 6, 2020 •
edited by bedevere-bot
Loading

CC @scoder

This function has no return value:

/Users/remi/src/cpython/Modules/_testcapimodule.c:6325:1: warning: control may reach end of non-void function [-Wreturn-type]
}

https://bugs.python.org/issue40724

@scoder scoder changed the title Fix return type of heapctypewithbuffer_releasebuffer() bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer() Jun 7, 2020
@scoder scoder added skip news needs backport to 3.9 only security fixes labels Jun 7, 2020
@scoder scoder merged commit b8867e5 into python:master Jun 7, 2020
@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@scoder
Copy link
Contributor

scoder commented Jun 7, 2020

Thanks!

@miss-islington
Copy link
Contributor

Sorry, @remilapeyre and @scoder, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b8867e5d5aca33511942632b5f4e359b9245b2fa 3.9

@scoder scoder added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jun 7, 2020
@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @remilapeyre and @scoder, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b8867e5d5aca33511942632b5f4e359b9245b2fa 3.9

@scoder scoder added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jun 7, 2020
@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 7, 2020
@bedevere-bot
Copy link

GH-20690 is a backport of this pull request to the 3.9 branch.

scoder pushed a commit that referenced this pull request Jun 7, 2020
@miss-islington @remilapeyre
bpo-40724: Fix return type of test helper function heapctypewithbuffe…
1d711f2 
…r_releasebuffer() (GH-20685) (GH-20690)

(cherry picked from commit b8867e5)
Co-authored-by: Rémi Lapeyre <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@remilapeyre @arun-mani-j
Fix return type of test helper function heapctypewithbuffer_releasebu…
d179a4d 
…ffer() (pythonGH-20685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scoder scoder

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remilapeyre @miss-islington @scoder @bedevere-bot @the-knights-who-say-ni