bpo-40637: Do not emit warnings for disabled builtin hashes #20937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is a test fix, thus I don't think a news entry is required here. |
test_hashlib emits some warnings when it cannot find some hashes as it assumes they failed to compile. Since we can disable hashes through configure, we emit the warnings only in the case that we did not intentionaly disable them.
stratakis
force-pushed
the
builtin_hashes_test_warnings
branch
from
58418b9 to
55aec53
Compare
|
@stratakis: Status check is done, and it's a success ✅ . |
|
Thanks @stratakis for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry @stratakis, I had trouble checking out the |
stratakis
added a commit
to stratakis/cpython
that referenced
this pull request
Jun 17, 2020
…thonGH-20937) test_hashlib emits some warnings when it cannot find some hashes as it assumes they failed to compile. Since we can disable hashes through configure, we emit the warnings only in the case that we did not intentionaly disable them. Automerge-Triggered-By: @tiran (cherry picked from commit 236a0f5) Co-authored-by: stratakis <[email protected]>
|
GH-20951 is a backport of this pull request to the 3.9 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_hashlib emits some warnings when it cannot find some hashes
as it assumes they failed to compile. Since we can disable hashes
through configure, we emit the warnings only in the case that we
did not intentionaly disable them.
https://bugs.python.org/issue40637
Automerge-Triggered-By: @tiran