Skip to content

bpo-41066: Update the comparison section for os vs pathlib #21261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2020
Merged

bpo-41066: Update the comparison section for os vs pathlib #21261

merged 4 commits into from
Aug 13, 2020

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jul 1, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 1, 2020
@srinivasreddy
Copy link
Contributor Author

Should be back ported to 3.8, 3.9 as well.

@srinivasreddy srinivasreddy changed the title bpo-41066: Update the correspondence section for os vs pathlib bpo-41066: Update the compar section for os vs pathlib Jul 1, 2020
@srinivasreddy srinivasreddy changed the title bpo-41066: Update the compar section for os vs pathlib bpo-41066: Update the comparison section for os vs pathlib Jul 1, 2020
nanjekyejoannah
nanjekyejoannah reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ping with @pitrou for his thought on this.

Looks trivial for a news entry.

@srinivasreddy
Copy link
Contributor Author

Agree that it is trivial to have a NEWS entry, so I removed it.

pitrou
pitrou approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you

pitrou
pitrou reviewed Aug 13, 2020
View reviewed changes
Doc/library/pathlib.rst
:func:`os.path.isdir` :meth:`Path.is_dir`
:func:`os.path.isfile` :meth:`Path.is_file`
:func:`os.path.islink` :meth:`Path.is_symlink`
:func:`os.link` :meth:`Path.link_to`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to quickly add os.symlink and Path.symlink_to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pitrou pitrou merged commit 0eb9deb into python:master Aug 13, 2020
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2020
@srinivasreddy @miss-islington
bpo-41066: Update the comparison section for os vs pathlib (pythonGH-…
bb99657 
…21261)

(cherry picked from commit 0eb9deb)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot
Copy link

GH-21863 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 13, 2020
@miss-islington
Copy link
Contributor

Sorry, @srinivasreddy and @pitrou, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0eb9deb4a62e6d9daa82bc2f67d1075864ca8ece 3.8

pitrou pushed a commit to pitrou/cpython that referenced this pull request Aug 13, 2020
@srinivasreddy @pitrou
[3.8] bpo-41066: Update the comparison section for os vs pathlib (pyt…
ea98f7b 
…honGH-21261).

(cherry picked from commit 0eb9deb)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot
Copy link

GH-21864 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 13, 2020
@miss-islington @srinivasreddy
bpo-41066: Update the comparison section for os vs pathlib (GH-21261)
3dd1153 
(cherry picked from commit 0eb9deb)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@srinivasreddy srinivasreddy deleted the bpo-41066 branch August 13, 2020 19:59
miss-islington pushed a commit that referenced this pull request Aug 13, 2020
@pitrou
[3.8] bpo-41066: Update the comparison section for os vs pathlib (GH-…
43b3e4c 
…21261) (GH-21864)

(cherry picked from commit 0eb9deb)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>

Automerge-Triggered-By: @pitrou
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@srinivasreddy @shihai1991
bpo-41066: Update the comparison section for os vs pathlib (pythonGH-…
3ae5814 
…21261)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@srinivasreddy
bpo-41066: Update the comparison section for os vs pathlib (pythonGH-…
5b5e05b 
…21261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

@eamanu eamanu eamanu approved these changes

@kk456852 kk456852 kk456852 approved these changes

Assignees

@pitrou pitrou

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@srinivasreddy @miss-islington @bedevere-bot @pitrou @eamanu @nanjekyejoannah @kk456852 @the-knights-who-say-ni