bpo-42036:Fixed unchecked return in Modules/posixmodule.c #22696

monocle-ai · 2020-10-14T15:42:38Z

Instance 1
File : Modules/posixmodule.c
Enclosing Function : os_times_impl
Function : GetProcessTimes@20
https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L8505
Issue in: user, kernel

Code extract:

    FILETIME create, exit, kernel, user;
    HANDLE hProc;
    hProc = GetCurrentProcess();
    GetProcessTimes(hProc, &create, &exit, &kernel, &user); <------ HERE
    /* The fields of a FILETIME structure are the hi and lo part
       of a 64-bit value expressed in 100 nanosecond units.

How can I fix it?
Correct reference usage found in Modules/timemodule.c at line 1133.
https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/timemodule.c#L1133
Code extract:

    BOOL ok;

    process = GetCurrentProcess();
    ok = GetProcessTimes(process, &creation_time, &exit_time, <------ HERE
                         &kernel_time, &user_time);
    if (!ok) {

Instance 2
File : Modules/posixmodule.c
Enclosing Function : posixmodule_exec
Function : dir_fd_converter
https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L15060
Issue in: ignored

Code extract:

    fd_specified("", -1);
    follow_symlinks_specified("", 1);
    dir_fd_and_follow_symlinks_invalid("chmod", DEFAULT_DIR_FD, 1);
    dir_fd_converter(Py_None, &ignored); <------ HERE
    dir_fd_unavailable(Py_None, &ignored);
    }

How can I fix it?
Correct reference usage found in Modules/posixmodule.c at line 1258.
https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L1258
Code extract:

dir_fd_unavailable(PyObject *o, void *p)
{
    int dir_fd;
    if (!dir_fd_converter(o, &dir_fd)) <------ HERE
        return 0;
    if (dir_fd != DEFAULT_DIR_FD) {

https://bugs.python.org/issue42036

**Instance 1** File : `Modules/posixmodule.c` Enclosing Function : `os_times_impl` Function : `GetProcessTimes@20` https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L8505 **Issue in**: _user, kernel_ **Code extract**: ```cpp FILETIME create, exit, kernel, user; HANDLE hProc; hProc = GetCurrentProcess(); GetProcessTimes(hProc, &create, &exit, &kernel, &user); <------ HERE /* The fields of a FILETIME structure are the hi and lo part of a 64-bit value expressed in 100 nanosecond units. ``` **How can I fix it?** Correct reference usage found in `Modules/timemodule.c` at line `1133`. https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/timemodule.c#L1133 **Code extract**: ```cpp BOOL ok; process = GetCurrentProcess(); ok = GetProcessTimes(process, &creation_time, &exit_time, <------ HERE &kernel_time, &user_time); if (!ok) { ``` --- **Instance 2** File : `Modules/posixmodule.c` Enclosing Function : `posixmodule_exec` Function : `dir_fd_converter` https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L15060 **Issue in**: _ignored_ **Code extract**: ```cpp fd_specified("", -1); follow_symlinks_specified("", 1); dir_fd_and_follow_symlinks_invalid("chmod", DEFAULT_DIR_FD, 1); dir_fd_converter(Py_None, &ignored); <------ HERE dir_fd_unavailable(Py_None, &ignored); } ``` **How can I fix it?** Correct reference usage found in `Modules/posixmodule.c` at line `1258`. https://github.com/siva-msft/cpython/blob/582aaf19e8b94a70c1f96792197770d604ba0fdf/Modules/posixmodule.c#L1258 **Code extract**: ```cpp dir_fd_unavailable(PyObject *o, void *p) { int dir_fd; if (!dir_fd_converter(o, &dir_fd)) <------ HERE return 0; if (dir_fd != DEFAULT_DIR_FD) { ```

the-knights-who-say-ni · 2020-10-14T15:42:42Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@monocle-ai

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Modules/posixmodule.c

github-actions · 2020-12-17T00:29:36Z

This PR is stale because it has been open for 30 days with no activity.

serhiy-storchaka · 2021-10-09T19:07:09Z

Modules/posixmodule.c

@@ -15022,7 +15027,10 @@ posixmodule_exec(PyObject *m)
    fd_specified("", -1);
    follow_symlinks_specified("", 1);
    dir_fd_and_follow_symlinks_invalid("chmod", DEFAULT_DIR_FD, 1);
-    dir_fd_converter(Py_None, &ignored);
+    if(!dir_fd_converter(Py_None, &ignored))


It never fails.

serhiy-storchaka · 2021-10-09T19:09:55Z

Modules/posixmodule.c

+    ok = GetProcessTimes(hProc, &create, &exit, &kernel, &user);
+    if (!ok) {
+        PyErr_SetFromWindowsErr(0);
+        return -1;


It is not even compiled.

Suggested change

return -1;

return NULL;

bedevere-bot · 2021-10-09T19:11:04Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

github-actions · 2022-03-21T00:09:34Z

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

github-actions · 2022-04-04T00:09:50Z

Closing this stale PR because the CLA is still not signed.

monocle-ai added 2 commits October 14, 2020 08:34

Update posixmodule.c

184714c

the-knights-who-say-ni added the CLA not signed label Oct 14, 2020

bedevere-bot added the awaiting review label Oct 14, 2020

Created 2020-10-15-07-33-50.bpo-42036.MonocleAI.rst

6045037

sweeneyde reviewed Oct 29, 2020

View reviewed changes

Modules/posixmodule.c Show resolved Hide resolved

Complying to PEP 7

1f5be74

github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020

serhiy-storchaka requested changes Oct 9, 2021

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Oct 9, 2021

serhiy-storchaka removed the CLA not signed label Oct 9, 2021

the-knights-who-say-ni added the CLA not signed label Oct 9, 2021

hugovk mentioned this pull request Feb 17, 2022

Cron job to close stale PRs python/core-workflow#93

Closed

github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 19, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 21, 2022

github-actions bot closed this Apr 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-42036:Fixed unchecked return in Modules/posixmodule.c #22696

bpo-42036:Fixed unchecked return in Modules/posixmodule.c #22696

Uh oh!

monocle-ai commented Oct 14, 2020 •

edited by bedevere-bot

Loading

Uh oh!

the-knights-who-say-ni commented Oct 14, 2020

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2020

Uh oh!

serhiy-storchaka Oct 9, 2021

Uh oh!

serhiy-storchaka Oct 9, 2021

Uh oh!

bedevere-bot commented Oct 9, 2021

Uh oh!

github-actions bot commented Mar 21, 2022

Uh oh!

github-actions bot commented Apr 4, 2022

Uh oh!

Uh oh!

Uh oh!

bpo-42036:Fixed unchecked return in Modules/posixmodule.c #22696

bpo-42036:Fixed unchecked return in Modules/posixmodule.c #22696

Uh oh!

Conversation

monocle-ai commented Oct 14, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Oct 14, 2020

Recognized GitHub username

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2020

Uh oh!

serhiy-storchaka Oct 9, 2021

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Oct 9, 2021

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Oct 9, 2021

Uh oh!

github-actions bot commented Mar 21, 2022

Uh oh!

github-actions bot commented Apr 4, 2022

Uh oh!

Uh oh!

monocle-ai commented Oct 14, 2020 •

edited by bedevere-bot

Loading