Skip to content

mark various test data binary #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2017
Merged

mark various test data binary #233

merged 1 commit into from
Feb 23, 2017

Conversation

benjaminp
Copy link
Contributor

It seems git's automatic LF -> CRLF translation for some binary data files is breaking the Windows buildbots. (My favorite is ModuleNotFoundError: No module named 'random\r'.) Turn that off .

@serhiy-storchaka
Copy link
Member

What about other binary data?

Lib/test/audiodata/*
Lib/test/imghdrdata/*
Lib/test/audiotest.au
Lib/test/Sine-1000Hz-300ms.aif
*.tar
*.zip
Lib/idlelib/Icons/*

and others.

@benjaminp
Copy link
Contributor Author

We can add those, too, but git seems to at least automatically recognize them as binary.

@benjaminp benjaminp merged commit 2771304 into master Feb 23, 2017
@benjaminp benjaminp deleted the benjamin-binary-test-data branch February 23, 2017 06:38
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233)
4c0e028
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233) (#303)
6e9e649
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233)
2334587
benjaminp added a commit that referenced this pull request Feb 26, 2017
@benjaminp
mark various test data binary (#233) (#304)
91c499f
@BCSharp BCSharp mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benjaminp @serhiy-storchaka @methane @berkerpeksag @Mariatta @the-knights-who-say-ni