Skip to content

bpo-43651: Fix EncodingWarning in test_file and test_file_eintr #25109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2021
Merged

bpo-43651: Fix EncodingWarning in test_file and test_file_eintr #25109

merged 2 commits into from
Apr 1, 2021

Conversation

methane
Copy link
Member

@methane methane commented Mar 31, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Mar 31, 2021
vstinner
vstinner reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the UTF-8 encoding :-) The "t" mode is ignored. I even propose to omit mode="r" since it's the default value, and I like to simply write open(filename) usually. Or now open(filename, encoding="utf-8").

vstinner
vstinner approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@methane methane merged commit 55f31be into python:master Apr 1, 2021
@methane methane deleted the fix-ew-test_file branch April 1, 2021 02:23
@methane methane mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @vstinner @the-knights-who-say-ni @bedevere-bot