Skip to content

bpo-44047: Remove unused statement argument to _pysqlite_seterror #25915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 5, 2021

@orsenthil
Copy link
Member

This looks good to me.

  • Is there a way to exercise this change? (Is there is a need to exercise this change via demo that things will continue to work?)

@erlend-aasland
Copy link
Contributor Author

  • Is there a way to exercise this change? (Is there is a need to exercise this change via demo that things will continue to work?)

I'll have a look at the coverage report from the test suite in a couple of hours. I'll see if it is possible to squeeze out a couple more corner cases. (Stuff like memory errors is of course hard to do, but not impossible.) I'll keep you posted :)

@berkerpeksag
Copy link
Member

  • Is there a way to exercise this change? (Is there is a need to exercise this change via demo that things will continue to work?)

st was only used here at e7ea745#diff-a1ebbfcd22aca69093f4f07f36a5b7a5968786b483d69b8fdf3493f6bed82613R52-R56 so this can be found even by a static analyzer. I'd say it's pretty safe.

@berkerpeksag berkerpeksag merged commit 0988ed0 into python:main May 7, 2021
@erlend-aasland erlend-aasland deleted the sqlite-remove-unused-err-argument branch May 7, 2021 13:16
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants