Skip to content

bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. #26577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 7, 2021

These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

https://bugs.python.org/issue43693

@ericsnowcurrently ericsnowcurrently removed the request for review from tiran June 7, 2021 15:24
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4eb1135e930dcea94483d350ac5ed92ee07f22ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@pablogsal
Copy link
Member

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

Thanks a lot @ericsnowcurrently ❤️

These were reverted in pythonGH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (pythongh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-localsplusnames branch from 4eb1135 to 1fb813c Compare June 7, 2021 18:04
@ericsnowcurrently
Copy link
Member Author

The buildbots say "the refleaks have been fixed". 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants