-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Fix typos #26689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #26689
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Why did you close this? The CLA? For spelling corrections, we merely prefer the CLA, but don't need it, as the change is from a 'creative' misspelling to the dictionary standard. You cannot copyright the correct spelling. I will apply this, but hope you go ahead and sign it now so you are ready for a future PR. The initial Pipelines failure? It is a build failure, which should be unrelated to the PR and should be transient. |
@terryjreedy Hi. Thanks for your reply. I am new. That means a lot to me. Thanks again for your time! |
Reverting configure.ac did not work, so I made sure updated to latest main. |
@terryjreedy - be careful with this one, I spotted some changes that weren't good. |
@cjw296 Please be specific. A couple of hours ago I reviewed carefully and already reverted, corrected, or checked everything I though questionable. |
@cjw296 I recheck and found this: in ssl.py, 'woth' should by 'with', not 'worth'. Fixed. I think others looks good in context. |
Bin-bin, If you (or anyone else) are on Linux and can run 'make regen-all' and commet whatever that changes, please try that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not on Linux right now, so I can't help with 'make regen-all', sorry.
But all of the corrections look good to me. Thanks, @enjoy-binbin and @terryjreedy.
@terryjreedy It seems that Sorry for that, i didn't expect to cause this problem... and others minor fix |
On corementorship, Guido said how to rebuild on windows: |
Thanks @enjoy-binbin for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, @enjoy-binbin and @terryjreedy, I could not cleanly backport this to |
Yes, more time than expected. At least I learned that rebuilding can be done on Windows. I have seen the make message before and assumed I had to have a make system. Another core def suggested that the error message should be more informative. I expected that auto backport would fail even though most of these misspelling either originated with or were backported at least to 3.10. If you do a 3.10 backport that passes tests , I will review and merge. Using the cherry_picker module is easier than git cherry-picker as it automates more. Whether and how are up to you. |
Co-authored-by: Terry Jan Reedy <[email protected]>. (cherry picked from commit 17b16e1) Co-authored-by: Binbin <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Correct minor spelling typos