Skip to content

Fix typos #26689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 13, 2021
Merged

Fix typos #26689

merged 13 commits into from
Jun 13, 2021

Conversation

enjoy-binbin
Copy link
Contributor

Correct minor spelling typos

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@enjoy-binbin

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@terryjreedy
Copy link
Member

terryjreedy commented Jun 12, 2021

Why did you close this? The CLA? For spelling corrections, we merely prefer the CLA, but don't need it, as the change is from a 'creative' misspelling to the dictionary standard. You cannot copyright the correct spelling. I will apply this, but hope you go ahead and sign it now so you are ready for a future PR.

The initial Pipelines failure? It is a build failure, which should be unrelated to the PR and should be transient.

@terryjreedy terryjreedy reopened this Jun 12, 2021
@terryjreedy terryjreedy self-assigned this Jun 12, 2021
@terryjreedy terryjreedy added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip issue skip news docs Documentation in the Doc dir labels Jun 12, 2021
@enjoy-binbin
Copy link
Contributor Author

enjoy-binbin commented Jun 12, 2021

@terryjreedy Hi. Thanks for your reply. I am new. That means a lot to me.
The only reason i closed it because the CLA... I have applied for the sign, juse wait the result
So that i can reopen again. Avoid disturbing you guys. But it seems that you have been mentioned

Thanks again for your time!

@terryjreedy terryjreedy removed the needs backport to 3.9 only security fixes label Jun 12, 2021
@terryjreedy
Copy link
Member

Reverting configure.ac did not work, so I made sure updated to latest main.

@cjw296 cjw296 removed their request for review June 12, 2021 19:07
@cjw296
Copy link
Contributor

cjw296 commented Jun 12, 2021

@terryjreedy - be careful with this one, I spotted some changes that weren't good.

@terryjreedy
Copy link
Member

@cjw296 Please be specific. A couple of hours ago I reviewed carefully and already reverted, corrected, or checked everything I though questionable.

@terryjreedy terryjreedy reopened this Jun 12, 2021
@terryjreedy
Copy link
Member

@cjw296 I recheck and found this: in ssl.py, 'woth' should by 'with', not 'worth'. Fixed. I think others looks good in context.

@isidentical isidentical removed their request for review June 12, 2021 19:52
@terryjreedy
Copy link
Member

Bin-bin, If you (or anyone else) are on Linux and can run 'make regen-all' and commet whatever that changes, please try that.

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not on Linux right now, so I can't help with 'make regen-all', sorry.

But all of the corrections look good to me. Thanks, @enjoy-binbin and @terryjreedy.

@enjoy-binbin
Copy link
Contributor Author

@terryjreedy It seems that re-gen was ok. I was trying to solve that one half hour ago.
But i only have a centos and i encounter some problems.
Now look like the hardest part has been solved.

Sorry for that, i didn't expect to cause this problem... and others minor fix
Thanks a lot, it must have cost you a lot of time

@terryjreedy
Copy link
Member

On corementorship, Guido said how to rebuild on windows: PCbuild\build -r. importlib_external.h was rebuilt, followed by errors that disappeared on rerun. I will redo the the misspellings I reverted and is that does not create a problem, merge.

@terryjreedy terryjreedy merged commit 17b16e1 into python:main Jun 13, 2021
@miss-islington
Copy link
Contributor

Thanks @enjoy-binbin for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @enjoy-binbin and @terryjreedy, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 17b16e13bb444001534ed6fccb459084596c8bcf 3.10

@terryjreedy
Copy link
Member

Yes, more time than expected. At least I learned that rebuilding can be done on Windows. I have seen the make message before and assumed I had to have a make system. Another core def suggested that the error message should be more informative.

I expected that auto backport would fail even though most of these misspelling either originated with or were backported at least to 3.10. If you do a 3.10 backport that passes tests , I will review and merge. Using the cherry_picker module is easier than git cherry-picker as it automates more. Whether and how are up to you.

@enjoy-binbin enjoy-binbin deleted the fix_typos branch June 13, 2021 03:36
enjoy-binbin added a commit to enjoy-binbin/cpython that referenced this pull request Jun 13, 2021
Co-authored-by: Terry Jan Reedy <[email protected]>.
(cherry picked from commit 17b16e1)

Co-authored-by: Binbin <[email protected]>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants