Skip to content

bpo-44512: Fix handling of extrasactions arg with mixed or upper case #26924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2022
Merged

bpo-44512: Fix handling of extrasactions arg with mixed or upper case #26924

merged 6 commits into from
Dec 9, 2022

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Jun 27, 2021 •
edited by bedevere-bot
Loading

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 28, 2021
MaxwellDupre
MaxwellDupre approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@akulakov akulakov mentioned this pull request Apr 10, 2022
Closed
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 10, 2022
iritkatriel
iritkatriel previously requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has merge conflicts now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@netlify
Copy link

netlify bot commented Dec 9, 2022 •
edited
Loading

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 0ec0945
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639356a3033e74000806e08e

@akulakov
Copy link
Contributor Author

akulakov commented Dec 9, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@iritkatriel: please review the changes made to this pull request.

@iritkatriel iritkatriel dismissed their stale review December 9, 2022 06:53

Conflict resolved.

@iritkatriel
Copy link
Member

Is this documented as case insensitive?

@akulakov
Copy link
Contributor Author

akulakov commented Dec 9, 2022

@iritkatriel it's not documented as case insensitive but it was already being implemented partly as case insensitive, so this PR is to fix the inconsistency in a way that doesn't break valid old code.

@iritkatriel
Copy link
Member

Got it. Please add a news file.

@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 9, 2022
@iritkatriel iritkatriel merged commit d0679c1 into python:main Dec 9, 2022
@miss-islington
Copy link
Contributor

Thanks @akulakov for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @akulakov and @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d0679c12398579fe9f10e78b6332dded119e4697 3.11

@miss-islington
Copy link
Contributor

Sorry @akulakov and @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d0679c12398579fe9f10e78b6332dded119e4697 3.10

@akulakov
Copy link
Contributor Author

akulakov commented Dec 9, 2022

@iritkatriel thanks for reviewing!

@akulakov akulakov deleted the 44512-CSV-Fix-handling-extrasaction-arg branch December 9, 2022 16:15
@iritkatriel iritkatriel removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees

@iritkatriel iritkatriel

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akulakov @bedevere-bot @iritkatriel @miss-islington @MaxwellDupre @the-knights-who-say-ni @ezio-melotti