-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-43950: Add documentation for PEP-657 #27047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ammaraskar can we separate |
Thanks @ammaraskar for taking the first pass on documentation. I think overall it looks great! |
Added a separate section for this to make it harder to miss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rebased and squashed with the CPython specific column limit removed. Hopefully the documentation conveys that you should always be prepared to handle Anything else to address here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's focus next on finishing the specialized formats so the docs are up to date with that
Updated the existing examples for #27037 but maybe we should put an example of a complicated arithmetic expression to show off that specialization as well? |
Yeah, I want to also prepare in a separate PR some mini tutorial/example on how to use the Python fields. We should also document "how to read the new tracebacks", especially for the specializations. For that, we should ask the one and only @willingc for advice on what's the best way to document it and where :) |
Co-authored-by: Pablo Galindo <[email protected]> Co-authored-by: Batuhan Taskaya <[email protected]> Co-authored-by: Ammar Askar <[email protected]>
Added an example for binary operations.
Definitely, both of those sound good for follow-up docs. Maybe we can ask the overarching docs working group and specifically cc Carol in for help :) |
Ready to go 🚀 |
Co-authored-by: Pablo Galindo Salgado <[email protected]>
Doc/reference/datamodel.rst
Outdated
- Running the interpreter with ``-X no_debug_ranges``. | ||
- Loading a pyc file compiled while using ``-X no_debug_ranges``. | ||
- Position tuples corresponding to artificial instructions. | ||
- Line and column numbers that can't be represented due to | ||
implementation specific limitations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Co-authored-by: Pablo Galindo Salgado <[email protected]>
First pass at documenting the feature.
https://bugs.python.org/issue43950