-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-43950: support some multi-line expressions for PEP 657 #27339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e rest of the line
ff6022e
to
8d8136f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall they we had this version implemented but we did abandoned it because it looked weird in done scenarios. I am missing anything or is the fact that we are stopping in whitespace enough to account for the problems with the old approach?
The old approach was highlighting the whole line if the |
Can you add some extra tests with some specific cases like function calls spawning multiple lines as well as binops spawning multiple lines (for example)? I will like to cover this with more cases if possible, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo my comment regarding more tests
@isidentical: Status check is done, and it's a success ✅ . |
This is basically something that I noticed up while fixing test runs for another issue. It is really common to have multiline calls, and when they fail the display is kind of weird since we omit the annotations. E.g;
This patch basically adds support for annotating the rest of the line, if the instruction covers multiple lines (start_line != end_line).
https://bugs.python.org/issue43950
Automerge-Triggered-By: GH:isidentical