Skip to content

bpo-44688: Remove ASCII limitation from sqlite3 collation names #27395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 27, 2021

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 27, 2021

cc. @encukou: ref. discussion in #27156 (comment)

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a terminology issue: the Python interface doesn't deal with UTF-8 (bytes); in py3 it always took a Unicode string.

For completeness, could you mention the pre-3.11 limitation in the documentation? (I think it's OK to only have it in the 3.11+ docs, but IMO it should be there for people porting code from 3.11 to previous versions.)

Erlend Egeberg Aasland and others added 3 commits July 28, 2021 10:22
@erlend-aasland
Copy link
Contributor Author

Nice! Just a terminology issue: the Python interface doesn't deal with UTF-8 (bytes); in py3 it always took a Unicode string.

Thanks for the heads up and the suggested improvements.

For completeness, could you mention the pre-3.11 limitation in the documentation? (I think it's OK to only have it in the 3.11+ docs, but IMO it should be there for people porting code from 3.11 to previous versions.)

Of course.

@erlend-aasland erlend-aasland requested a review from encukou July 28, 2021 08:35
@erlend-aasland
Copy link
Contributor Author

The address sanitiser test timed out during one of the multiprocessing tests. Looks unrelated.

https://github.com/python/cpython/pull/27395/checks?check_run_id=3181419480

@encukou
Copy link
Member

encukou commented Jul 28, 2021

I see @pablogsal added the address sanitizer in #26640.
Is it normally flaky?

@encukou encukou closed this Jul 28, 2021
@encukou encukou reopened this Jul 28, 2021
@pablogsal
Copy link
Member

I see @pablogsal added the address sanitizer in #26640.
Is it normally flaky?

No regarding detection of problems but a small subset of times it times out. What error are you experiencing?

@erlend-aasland
Copy link
Contributor Author

Is it normally flaky?

No regarding detection of problems but a small subset of times it times out. What error are you experiencing?

test_get in test_multiprocessing_fork timed out in both test runs on the last CI run. I can't recall seeing that particular failure before. See attached log.

log.txt

@encukou encukou merged commit 5269c09 into python:main Jul 29, 2021
@erlend-aasland erlend-aasland deleted the sqlite-remove-collation-ascii-limitation branch July 29, 2021 09:51
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants