Skip to content

gh-88929: remove outdated reference to Py_USING_MEMORY_DEBUGGER #27509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

fbidu
Copy link
Contributor

@fbidu fbidu commented Jul 31, 2021

Small fix, removes a line that's no longer necessary

https://bugs.python.org/issue44766

@fbidu fbidu changed the title bpo-4476: remove outdated reference to Py_USING_MEMORY_DEBUGGER bpo-44766: remove outdated reference to Py_USING_MEMORY_DEBUGGER Jul 31, 2021
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update.

@fbidu
Copy link
Contributor Author

fbidu commented Aug 2, 2021

thanks for the review, @shihai1991

@shihai1991
Copy link
Member

shihai1991 commented Aug 2, 2021

Hm, I haven't the merge right.
Hi, Victor. This is a small change of docs. Would you mind to take a look when you have free time? Thanks. @vstinner

@ammaraskar
Copy link
Member

For reference, this was removed as part of: 3924f93

Note that there are still references to Py_USING_MEMORY_DEBUGGER in:

# You must edit Objects/obmalloc.c and uncomment Py_USING_MEMORY_DEBUGGER
# to use the preferred suppressions with address_in_range.

and

#ifndef Py_USING_MEMORY_DEBUGGER

These stale references should probably be removed as well.

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 4, 2021
@vstinner
Copy link
Member

vstinner commented Sep 7, 2021

Please address Ammar's comment.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Sep 8, 2021
@fbidu
Copy link
Contributor Author

fbidu commented Sep 13, 2021

oh, sorry @vstinner, this fell off of my radar. Will do now

@fbidu
Copy link
Contributor Author

fbidu commented Sep 13, 2021

Done, hope I didn't break the C directives with this...

@fbidu fbidu requested a review from vstinner September 14, 2021 13:10
@@ -330,7 +330,6 @@ Bigint {

typedef struct Bigint Bigint;

#ifndef Py_USING_MEMORY_DEBUGGER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdickinson: Should we add a new macro to enable or disable the freelist, for debug purposes?

@arhadthedev arhadthedev changed the title bpo-44766: remove outdated reference to Py_USING_MEMORY_DEBUGGER gh-88929: remove outdated reference to Py_USING_MEMORY_DEBUGGER Feb 13, 2023
@arhadthedev
Copy link
Member

This PR is a de-facto continuation of gh-30284.

@arhadthedev arhadthedev added interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed skip news labels Feb 13, 2023
@arhadthedev
Copy link
Member

@benjaminp (as the merger of gh-30284 that removed not all references indeed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants