-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-88929: remove outdated reference to Py_USING_MEMORY_DEBUGGER
#27509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update.
thanks for the review, @shihai1991 |
Hm, I haven't the merge right. |
For reference, this was removed as part of: 3924f93 Note that there are still references to cpython/Misc/valgrind-python.supp Lines 10 to 11 in bb3e0c2
and Line 333 in bb3e0c2
These stale references should probably be removed as well. |
This PR is stale because it has been open for 30 days with no activity. |
Please address Ammar's comment. |
oh, sorry @vstinner, this fell off of my radar. Will do now |
Done, hope I didn't break the C directives with this... |
@@ -330,7 +330,6 @@ Bigint { | |||
|
|||
typedef struct Bigint Bigint; | |||
|
|||
#ifndef Py_USING_MEMORY_DEBUGGER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdickinson: Should we add a new macro to enable or disable the freelist, for debug purposes?
Py_USING_MEMORY_DEBUGGER
This PR is a de-facto continuation of gh-30284. |
@benjaminp (as the merger of gh-30284 that removed not all references indeed). |
Small fix, removes a line that's no longer necessary
https://bugs.python.org/issue44766