Skip to content

bpo-30822: Fix testing of datetime module. #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2017
Merged

bpo-30822: Fix testing of datetime module. #2783

merged 1 commit into from
Jul 21, 2017

Conversation

musically-ut
Copy link
Contributor

Only C implementation was being tested.

This reapplies the commit reverted in #2588. The testing of datetime module should not timeout on the build-bots now, thanks to #2775.

@mention-bot
Copy link

@musically-ut, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalkin, @serhiy-storchaka and @birkenfeld to be potential reviewers.

@musically-ut
Copy link
Contributor Author

I'm not sure why AppVeyor thinks that this PR is non-mergeable.

@vstinner
Copy link
Member

Ok, let's retry testing Lib/datetime.py :-)

@vstinner vstinner merged commit 287c559 into python:master Jul 21, 2017
@vstinner
Copy link
Member

I merged the PR. It was already approved and merged in PR #2530. I reverted the first attempt because test_datetime became too slow on some buildbots where the test timed out and so made tests failing.

We agreed on http://bugs.python.org/issue30822#msg297760 to exclude the slow tzdata resource to not test all timezones in test_datetime on buildbots, but only run a few selected timezones.

So I merged this new PR which is just a copy of the first one ;-)

Thank you again @musically-ut, sorry for the mess ;-)

I'm not sure why AppVeyor thinks that this PR is non-mergeable.

No idea.

@vstinner
Copy link
Member

vstinner commented Jul 21, 2017 •
edited
Loading

Please wait one or two days until all buildbots have time to run test_datetime at least once, to see if the bug is really fixed (test_datetime), before working on backports.

@musically-ut
Copy link
Contributor Author

I'm afraid I don't really know how to read the waterfall chart at http://buildbot.python.org/all/waterfall.

Is there a guide to reading the chart or an easy way to figure out:

  • This commit has been tested.
  • Which failures (if any) were caused by this merge.

?

It seems that bbreport is a bit dated.

@vstinner
Copy link
Member

I replied at http://bugs.python.org/issue30822#msg298786

musically-ut added a commit to musically-ut/cpython that referenced this pull request Jul 22, 2017
@musically-ut
[3.5] bpo-30822: Fix testing of datetime module. (pythonGH-2530) (pyt…
3ecb28a 
…honGH-2783)

Only C implementation was tested..
(cherry picked from commit 287c559)
musically-ut added a commit to musically-ut/cpython that referenced this pull request Jul 22, 2017
@musically-ut
[3.6] bpo-30822: Fix testing of datetime module. (pythonGH-2530) (pyt…
ee2799c 
…honGH-2783)

Only C implementation was tested.
(cherry picked from commit 287c559)
musically-ut added a commit to musically-ut/cpython that referenced this pull request Jul 22, 2017
@musically-ut
[3.6] bpo-30822: Fix testing of datetime module. (pythonGH-2530) (pyt…
b187f0b 
…honGH-2783)

Only C implementation was tested..
(cherry picked from commit 287c559)
vstinner pushed a commit that referenced this pull request Jul 26, 2017
@musically-ut @vstinner
[3.6] bpo-30822: Fix testing of datetime module. (GH-2530) (GH-2783) (#…
c52cea4 
…2816)

* [3.6] bpo-30822: Fix testing of datetime module. (GH-2530) (GH-2783)

Only C implementation was tested.
(cherry picked from commit 287c559)

* [3.6] bpo-30822: Fix testing of datetime module. (GH-2530) (GH-2783)

Only C implementation was tested..
(cherry picked from commit 287c559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@musically-ut @mention-bot @vstinner @Mariatta @the-knights-who-say-ni