Skip to content

Update errors.rst #28148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update errors.rst #28148

wants to merge 1 commit into from

Conversation

Ronbalt
Copy link

@Ronbalt Ronbalt commented Sep 3, 2021

Just a typo since the code example above indicates that an IOError is thrown, and not an OSError.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Ronbalt

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Sep 3, 2021
@serhiy-storchaka
Copy link
Member

Should not OSError be used?

@Ronbalt
Copy link
Author

Ronbalt commented Sep 10, 2021

Should not OSError be used?

Do you mean in the example itself?
I do not really care what exception to be used as long as it is consistent with the output.

@@ -291,7 +291,7 @@ This can be useful when you are transforming exceptions. For example::
Traceback (most recent call last):
File "<stdin>", line 2, in <module>
File "<stdin>", line 2, in func
OSError
IOError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would have thought so, but actually IOError is an alias for OSError and this output is actually correct. I would suggest to replace the exception by some other type which is more suitable for a tutorial example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> str(IOError)
"<class 'OSError'>"

@Mariatta
Copy link
Member

Can you create this against the main branch first? Or does it not exist in the main branch?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 18, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions bot closed this Mar 4, 2022
@hugovk
Copy link
Member

hugovk commented Mar 6, 2022

Just a note that any IOError / OSError confusion was cleared up in #23160 by replacing it with ConnectionError.

Also that was merged in December 2020, 9 months before this was opened. It was probably missed since this opened against the 3.9 branch instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants