-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Update errors.rst #28148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errors.rst #28148
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Should not OSError be used? |
Do you mean in the example itself? |
@@ -291,7 +291,7 @@ This can be useful when you are transforming exceptions. For example:: | |||
Traceback (most recent call last): | |||
File "<stdin>", line 2, in <module> | |||
File "<stdin>", line 2, in func | |||
OSError | |||
IOError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would have thought so, but actually IOError is an alias for OSError and this output is actually correct. I would suggest to replace the exception by some other type which is more suitable for a tutorial example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> str(IOError)
"<class 'OSError'>"
Can you create this against the |
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
Closing this stale PR because the CLA is still not signed. |
Just a note that any Also that was merged in December 2020, 9 months before this was opened. It was probably missed since this opened against the |
Just a typo since the code example above indicates that an IOError is thrown, and not an OSError.