Skip to content

bpo-45128: fixes test_multiprocessing_fork mysterious crash #28387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2021
Merged

bpo-45128: fixes test_multiprocessing_fork mysterious crash #28387

merged 7 commits into from
Sep 19, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 16, 2021 •
edited by bedevere-bot
Loading

Several thoughts on this:

  1. Thanks a lot for @vstinner and @pablogsal for providing extra information about this crash
  2. I feel obligated to fix this due to bpo-45052: Unskips a failing test_shared_memory_basics test #28182 (comment)
  3. This is not a trivial test flow, I hope that I got it right, but very careful review is required (we cannot even catch this in CI, what was the initial problem)
  4. I hope, that this won't happen again! 👍

https://bugs.python.org/issue45128

@sobolevn sobolevn requested a review from vsajip as a code owner September 16, 2021 14:26
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 16, 2021
@sobolevn
Copy link
Member Author

Maybe I can add some extra tests to catch this 🤔

@sobolevn sobolevn mentioned this pull request Sep 16, 2021
Merged
@sobolevn
Copy link
Member Author

I've created a bpo entry for this Windows build failures: https://bugs.python.org/issue45220

vstinner
vstinner reviewed Sep 16, 2021
View reviewed changes
vstinner
vstinner reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a PR with only replace del ... with with .... No need to go further.

vstinner
vstinner reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your PR on the main branch to get the fix for the Windows build.

@sobolevn
Copy link
Member Author

Rebased ♻️

@pablogsal pablogsal merged commit 1d42408 into python:main Sep 19, 2021
@pablogsal
Copy link
Member

Thanks a lot for the fix @sobolevn!

Does this need to be backported to something before 3.10?

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Sep 19, 2021
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 19, 2021
@sobolevn @miss-islington
bpo-45128: fixes test_multiprocessing_fork mysterious crash (python…
cfea1c9 
…GH-28387)

(cherry picked from commit 1d42408)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

GH-28462 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 19, 2021
miss-islington added a commit that referenced this pull request Sep 19, 2021
@miss-islington @sobolevn
bpo-45128: fixes test_multiprocessing_fork mysterious crash (GH-28387)
0e96086 
(cherry picked from commit 1d42408)

Co-authored-by: Nikita Sobolev <[email protected]>
pablogsal pushed a commit that referenced this pull request Sep 19, 2021
@miss-islington @sobolevn @pablogsal
bpo-45128: fixes test_multiprocessing_fork mysterious crash (GH-28387)
7661103 
(cherry picked from commit 1d42408)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
Copy link
Member Author

Thanks, everyone!

@pablogsal no, this test does not exist in 3.9
https://github.com/python/cpython/blob/3.9/Lib/test/test_logging.py

niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@sobolevn @niyas-sait
bpo-45128: fixes test_multiprocessing_fork mysterious crash (python…
b5ab1dd 
…GH-28387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@pablogsal pablogsal pablogsal approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @pablogsal @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni