Skip to content

Fix doctest doc examples for syntax errors #28486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Sep 21, 2021

Not sure if this needs a bpo issue, I can add if needed.

This can be backported to 3.10, but not to 3.9 or earlier.

With introduction of SyntaxError error range indication with carets (^^^), two examples in doctests are inaccurate and confusing.

Note that while it's indexed as single: ^ (caret), that doesn't need to be updated as in the index it's listed under caret (marker), which works fine for this doc section.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Sep 21, 2021
@akulakov akulakov marked this pull request as draft September 21, 2021 02:19
@akulakov akulakov marked this pull request as ready for review September 21, 2021 02:47
@pablogsal
Copy link
Member

This can be backported to 3.10, but not to 3.9 or earlier.

This cannot be backported to 3.10 because is using 657

@pablogsal pablogsal merged commit f76889a into python:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants