Fix build error for python 3.11 on win/arm64 target #28491
Conversation
frozen_modules was set to compile for amd64 target for win/arm64 configuration. Project files updated to use correct target
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: @nsait-linaro For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
PCbuild/pcbuild.proj
Outdated
| @@ -17,7 +17,7 @@ | |||
| <FreezeProjects> | |||
| <Platform>$(Platform)</Platform> | |||
| <Platform Condition="$(Platform) == 'ARM'">Win32</Platform> | |||
| <Platform Condition="$(Platform) == 'ARM64'">x64</Platform> | |||
| <Platform Condition="$(Platform) == 'ARM64'">ARM64</Platform> | |||
There was a problem hiding this comment.
This platform needs to match the host machine (doing the build), not the target architecture, because these projects are run as part of build.
Maybe there's another property that can be used to check the host platform?
PCbuild/pcbuild.sln
Outdated
| {19C0C13F-47CA-4432-AFF3-799A296A4DDC}.Debug|ARM64.ActiveCfg = Debug|x64 | ||
| {19C0C13F-47CA-4432-AFF3-799A296A4DDC}.Debug|ARM64.Build.0 = Debug|x64 | ||
| {19C0C13F-47CA-4432-AFF3-799A296A4DDC}.Debug|ARM64.ActiveCfg = Debug|ARM64 | ||
| {19C0C13F-47CA-4432-AFF3-799A296A4DDC}.Debug|ARM64.Build.0 = Debug|ARM64 |
There was a problem hiding this comment.
Same as above. Until the only people building for ARM64 are running on ARM64 (which seems a long way off), these projects need to match the host machine.
Tools/scripts/freeze_modules.py
Outdated
| @@ -34,7 +34,7 @@ | |||
| sys.exit("ERROR: missing _freeze_module") | |||
| else: | |||
| def find_tool(): | |||
| for arch in ['amd64', 'win32']: | |||
| for arch in ['amd64', 'win32', 'arm64']: | |||
There was a problem hiding this comment.
This change is fine, but should probably also check whether it's running in an ARM64 build of Python first. If this is an x86/x64 build, there's no point trying to launch the ARM64 binary.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks, @zooba. I use native arm64 compilation of cpython a lot in my workflow so I am keen to have the native compilation supported as well. Would it be acceptable if a new host platform property is added to the project file and keep x64 or x86 as default (depends on target) but allow users to configure a different host platform to allow native arm64 compilation? |
Yes, but see if there's anything that already exists that it set automatically. Browsing through properties that I can see, |
Unfortunately, I cannot find any of the properties listed above set automatically for MSBuild. I've checked the documentaiton and I don't see any of them listed for use. I am fairly new to VS and MSBuild so I might be missing something obivious. I managed to use another property called |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @zooba: please review the changes made to this pull request. |
Python 3.11 build was failing on win/arm64 target due to one of the component (_frozen_module) set to target amd64 instead of arm64 target.