-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45512: Simplify isolation_level handling in sqlite3
#29053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI: |
Regenerate clinic
Some more information about these changes, for the reviewers convenience. In addition to the refactoring needed to merge During |
Dang, there's a ref. leak. I'll ping you when I've found it, @corona10. |
Finally got around to revisit this; fixed the ref. leak, @corona10. Does this look ok to you? |
I will take a look by next week |
This simplifies get_begin_statement(), and removes the need to call strlen() in __init__()
Regenerate clinic
Thanks, I will take a look one more time :) |
Thank you for reviewing, Dong-hee! |
Simplify reference handling and merge two connection object members:
PyObject *
memberisolation_level
from connection object(self->begin_statement carries the information we need)
get_begin_statement()
helper for converting isolation level to begin statementsqlite3.Connection.__init__
by usingget_begin_statement
https://bugs.python.org/issue45512