Skip to content

bpo-45126: Ensure sqlite3.Connection is unusable if __init__ fails #29160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-45126: Ensure sqlite3.Connection is unusable if __init__ fails #29160

wants to merge 4 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 22, 2021 •
edited by bedevere-bot
Loading

If sqlite3.Connection.__init__() fails, explicitly set self->db and
self->initialized to NULL/zero.

https://bugs.python.org/issue45126

Erlend E. Aasland added 2 commits October 22, 2021 14:55
bpo-45126: Ensure sqlite3.Connection is unusable if __init__ fails
b7bd29a 
If sqlite3.Connection.__init__() fails, always leave it with self->db
and self->initialized set to NULL/zero.
Add NEWS
4959f77
@erlend-aasland
Copy link
Contributor Author

Not sure if it is a good idea to include a NEWS entry here. We don't want to encourage re-init for connection objects.

@erlend-aasland erlend-aasland mentioned this pull request Oct 22, 2021
Merged
@erlend-aasland
Copy link
Contributor Author

cc. @encukou
cc. @malemburg ref. your comment on Discourse

@erlend-aasland
Copy link
Contributor Author

FYI, the exception set by _pysqlite_seterror after a failed sqlite3_open_v2 may be incorrect. We should use the result code from sqlite3_open_v2 when setting that exception, instead of fetching the error code from the database pointer. I fix that in a separate PR.

@erlend-aasland
Copy link
Contributor Author

This PR was a little bit rushed; this approach is totally wrong; sorry for the noise. GH-28227 is a much better approach.

@erlend-aasland erlend-aasland deleted the sqlite-reinit-segfault branch October 22, 2021 19:13
@erlend-aasland erlend-aasland mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@encukou encukou Awaiting requested review from encukou

@malemburg malemburg Awaiting requested review from malemburg

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @the-knights-who-say-ni @bedevere-bot