Skip to content

[3.10] bpo-45678: Add more singledispatchmethod tests (GH-29412) #29424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 5, 2021

In order to fix a bug in the 3.9 branch in GH-29394, more tests were added to
test_functools.py to ensure that singledispatchmethod still correctly
wrapped a target method, even if the target method had already been wrapped by
multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
(cherry picked from commit 32f55d1)

Co-authored-by: Alex Waygood [email protected]

https://bugs.python.org/issue45678

In order to fix a bug in the 3.9 branch in pythonGH-29394, more tests were added to
``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly
wrapped a target method, even if the target method had already been wrapped by
 multiple other decorators. This PR brings the new tests into the 3.11 and 3.10
branches as well.
(cherry picked from commit 32f55d1)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Nov 5, 2021
@ambv ambv merged commit bcb236c into python:3.10 Nov 5, 2021
@miss-islington miss-islington deleted the backport-32f55d1-3.10 branch November 5, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants