Skip to content

bpo-45701: Improve documentation for *typed* parameter #29498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 9, 2021

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Nov 9, 2021

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But would not be simpler to use int and float in examples?

@rhettinger
Copy link
Contributor Author

I avoided int and str in the examples to be clear that we're not talking about the special cases in this paragraph.

@rhettinger rhettinger merged commit 912a4cc into python:main Nov 9, 2021
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2021
(cherry picked from commit 912a4cc)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 9, 2021
@bedevere-bot
Copy link

GH-29509 is a backport of this pull request to the 3.10 branch.

thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
ambv pushed a commit that referenced this pull request Nov 18, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants