bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files #29501
Conversation
zooba
added
skip news
needs backport to 3.9
zooba
changed the title
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry @zooba, I had trouble checking out the |
|
GH-29503 is a backport of this pull request to the 3.9 branch. |
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| #include "python_ver_rc.h" | |||
|
|
|||
| #ifndef RT_MANIFEST | |||
| // bpo-45220: Cannot reliably #include RT_MANIFEST from | |||
There was a problem hiding this comment.
The issue was with #include <winuser.h>, no?
There was a problem hiding this comment.
Does it matter? We no longer need to include any C++ headers here (you're not meant to include winuser.h directly anyway).
There was a problem hiding this comment.
It's just that I don't understand what #include RT_MANIFEST means. I guess that you mean that we cannot add an include to get the RT_MANIFEST constant. It's just a remark about the comment. You can ignore it ;-)
…rce files (pythonGH-29501) (cherry picked from commit a56fbad) Co-authored-by: Steve Dower <[email protected]>
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…rce files (pythonGH-29501) (cherry picked from commit a56fbad) Co-authored-by: Steve Dower <[email protected]>
|
GH-29504 is a backport of this pull request to the 3.10 branch. |
…rce files (GH-29501) (cherry picked from commit a56fbad) Co-authored-by: Steve Dower <[email protected]>
…rce files (GH-29501) (cherry picked from commit a56fbad) Co-authored-by: Steve Dower <[email protected]>
https://bugs.python.org/issue45220