bpo-45799: [Doc] improve confusing sentence in __main__.rst #29546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvsmith
requested changes
Nov 13, 2021
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again.
…On Sat, Nov 13, 2021 at 11:03 AM Eric V. Smith ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Doc/library/__main__.rst
<#29546 (comment)>:
> @@ -116,8 +116,8 @@ Idiomatic Usage
^^^^^^^^^^^^^^^
Some modules contain code that is intended for script use only, like parsing
-command-line arguments or fetching data from standard input. When a module
-like this were to be imported from a different module, for example to unit test
+command-line arguments or fetching data from standard input. If a module
+like this is imported from a different module, for example to unit test
I think this would read better as "was imported", to match "would
unintentionally execute" later in the same sentence.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29546 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7GD5E452BKGIGYVMIG5FLUL2D4TANCNFSM5H6WKYKA>
.
|
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
|
Thanks @jdevries3133 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2021
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit f8da00e) Co-authored-by: Jack DeVries <[email protected]>
|
GH-29549 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 13, 2021
I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit f8da00e) Co-authored-by: Jack DeVries <[email protected]>
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't technically a typo, but definitely confusing wording. This PR fixes the confusing sentence.
https://bugs.python.org/issue45799
Automerge-Triggered-By: GH:ericvsmith