-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-45799: [Doc] improve confusing sentence in __main__.rst #29546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again.
…On Sat, Nov 13, 2021 at 11:03 AM Eric V. Smith ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Doc/library/__main__.rst
<#29546 (comment)>:
> @@ -116,8 +116,8 @@ Idiomatic Usage
^^^^^^^^^^^^^^^
Some modules contain code that is intended for script use only, like parsing
-command-line arguments or fetching data from standard input. When a module
-like this were to be imported from a different module, for example to unit test
+command-line arguments or fetching data from standard input. If a module
+like this is imported from a different module, for example to unit test
I think this would read better as "was imported", to match "would
unintentionally execute" later in the same sentence.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29546 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7GD5E452BKGIGYVMIG5FLUL2D4TANCNFSM5H6WKYKA>
.
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Thanks @jdevries3133 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit f8da00e) Co-authored-by: Jack DeVries <[email protected]>
GH-29549 is a backport of this pull request to the 3.10 branch. |
I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith (cherry picked from commit f8da00e) Co-authored-by: Jack DeVries <[email protected]>
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith
…-29546) I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. Automerge-Triggered-By: GH:ericvsmith
I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't technically a typo, but definitely confusing wording. This PR fixes the confusing sentence.
https://bugs.python.org/issue45799
Automerge-Triggered-By: GH:ericvsmith