Skip to content

[3.9] bpo-45820: Fix a segfault when the parser fails without reading any input (GH-29580) #29584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 16, 2021

(cherry picked from commit df4ae55)

Co-authored-by: Pablo Galindo Salgado [email protected]

https://bugs.python.org/issue45820

…nput (pythonGH-29580)

(cherry picked from commit df4ae55)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington
Copy link
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .

if (p->fill == 0) {
va_list va;
va_start(va, errmsg);
_PyPegen_raise_error_known_location(p, errtype, 0, 0, 0, -1, errmsg, va);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_PyPegen_raise_error_known_location only gained end_lineno and end_col_offset in 3.10+ in GH-25525.

@ambv ambv merged commit 00ee14e into python:3.9 Nov 18, 2021
@miss-islington miss-islington deleted the backport-df4ae55-3.9 branch November 18, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants