-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-45019: Cleanup module freezing and deepfreeze #29772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @gvanrossum |
928e1ff
to
3bfd1cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without looking carefully yet, I think I like your cleanup of freeze_modules.py, but not the rename of the deepfreeze directory. Can you undo the latter and just focus on improving the script?
EDIT: @gvanrossum done |
8fae1f6
to
db00ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I have a few nits.
I also wonder if there aren't more improvements we can make, e.g. use relative paths throughout the code, rather than computing absolute paths and then making them relative for the generated code again.
Oh, and it would be nice to be able to freeze some submodules in a package but not all of them -- e.g. I'd like to freeze encodings/{__init__,utf_8,aliases}.py
but not the remaining 100 submodules in that package.
Freeze encoding here #29788 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for this phase! I'll merge this now. Then you can work on e.g. changes groups of functions to classes and partially freezing encodings.
@gvanrossum: Please replace |
Thanks @gvanrossum This was my first contribution to cpython, earlier was just a typo fix, glad that you merged it :). |
Thanks Kumar for cleaning up our mess! :-) I am looking forward to seeing more from you. |
https://bugs.python.org/issue45019