bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) #29873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces installation size of browser bundle Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-40280-ensurepip
branch
from
9678387 to
4f8cc1a
Compare
emmatyping
reviewed
Dec 1, 2021
| [with_ensurepip=upgrade]) | ||
| [ | ||
| AS_CASE([$ac_sys_system], | ||
| [Emscripten], [$with_ensurepip=no], |
There was a problem hiding this comment.
Should we disable ensurepip for WASI as well?
There was a problem hiding this comment.
I prefer to wait until we have WASI builds working and more experience with WASI.
brettcannon
approved these changes
Dec 1, 2021
tiran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces installation size of browser bundle
https://bugs.python.org/issue40280