Skip to content

bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 6, 2022

raise NotImplementedError

def call_at(self, when, callback, *args):
def call_at(self, when, callback, *args, cotext=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def call_at(self, when, callback, *args, cotext=None):
def call_at(self, when, callback, *args, context=None):

@asvetlov asvetlov merged commit 3e43fac into main Jan 6, 2022
@asvetlov asvetlov deleted the fix-asyncio-contracts branch January 6, 2022 12:31
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@bedevere-bot
Copy link

GH-30428 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@bedevere-bot
Copy link

GH-30429 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 6, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 6, 2022
asvetlov added a commit that referenced this pull request Jan 6, 2022
…) (#30429)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <[email protected]>

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Jan 6, 2022
…) (GH-30428)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <[email protected]>

Co-authored-by: Andrew Svetlov <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington pushed a commit that referenced this pull request Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <[email protected]>
asvetlov pushed a commit that referenced this pull request Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <[email protected]>

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants