bpo-45569: Change PYLONG_BITS_IN_DIGIT default to 30 #30497
Conversation
mdickinson
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 515c0e8 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
There were 5 buildbot failures, none of which appears to be directly related to this PR. Most of them seem to be due to an enum module refleak, which has since been corrected (see https://bugs.python.org/issue46301). The ARM64/macOS PR is failing due to test_ftplib changing the environment. I'll re-do the buildbot run, in the hope of seeing the refleak-related failures disappear. |
mdickinson
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 515c0e8 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
mdickinson
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 8a761bf 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@tiran Would you have bandwidth to do a sanity check on this PR? |
|
Hmm. I need to update the wording in the |
| to the ``configure`` script, or by defining ``PYLONG_BITS_IN_DIGIT`` in | ||
| ``pyconfig.h``. |
There was a problem hiding this comment.
pyconfig.h is auto-generated and not user-editable. I suggest to remove the qualifier.
| to the ``configure`` script, or by defining ``PYLONG_BITS_IN_DIGIT`` in | |
| ``pyconfig.h``. | |
| to the ``configure`` script, or by defining ``PYLONG_BITS_IN_DIGIT``. |
There was a problem hiding this comment.
True; I was thinking of the Windows setup. Maybe replacing pyconfig.h with PC/pyconfig.h would be enough?
There was a problem hiding this comment.
OTOH, probably not worth worrying about explicitly specifying how to change things for Windows here.
| @@ -5039,7 +5039,7 @@ AC_CHECK_DECLS([RTLD_LAZY, RTLD_NOW, RTLD_GLOBAL, RTLD_LOCAL, RTLD_NODELETE, RTL | |||
| # determine what size digit to use for Python's longs | |||
| AC_MSG_CHECKING([digit size for Python's longs]) | |||
| AC_ARG_ENABLE(big-digits, | |||
| AS_HELP_STRING([--enable-big-digits@<:@=15|30@:>@],[use big digits (30 or 15 bits) for Python longs (default is system-dependent)]]), | |||
There was a problem hiding this comment.
You have to update configure, too. It's a trivial change, so manually editing is easier.
There was a problem hiding this comment.
Yes, I've spent the last hour trying to get autoreconf to not generate spurious changes. :-( I'll go for the manual edit option.
There was a problem hiding this comment.
Yes, I've spent the last hour trying to get
autoreconfto not generate spurious changes. :-( I'll go for the manual edit option.
I have you covered: https://quay.io/repository/tiran/cpython_autoconf
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Thanks, @tiran! |
This PR changes the default for
PYLONG_BITS_IN_DIGITto 30, unconditionally. 15-bit digits can still be selected explicitly viaconfigure(Unix-like) or inpyconfig.h(Windows).https://bugs.python.org/issue45569