Skip to content

bpo-46425: fix direct invocation of test_importlib #30682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/builtin/test_finder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/builtin/test_loader.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from test.support import os_helper
import unittest
import sys
from .. import util
from test.test_importlib import util

importlib = util.import_importlib('importlib')
machinery = util.import_importlib('importlib.machinery')
Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/extension/test_finder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/extension/test_loader.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from warnings import catch_warnings
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/extension/test_path_hook.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util

machinery = util.import_importlib('importlib.machinery')

Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/frozen/test_finder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/frozen/test_loader.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test___loader__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import unittest
import warnings

from .. import util
from test.test_importlib import util


class SpecLoaderMock:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test___package__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"""
import unittest
import warnings
from .. import util
from test.test_importlib import util


class Using__package__:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_api.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util

from importlib import machinery
import sys
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_caching.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Test that sys.modules is used properly by import."""
from .. import util
from test.test_importlib import util
import sys
from types import MethodType
import unittest
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_fromlist.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Test that the semantics relating to the 'fromlist' argument are correct."""
from .. import util
from test.test_importlib import util
import warnings
import unittest

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_meta_path.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util
import importlib._bootstrap
import sys
from types import MethodType
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_packages.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util
import sys
import unittest
from test import support
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_path.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util

importlib = util.import_importlib('importlib')
machinery = util.import_importlib('importlib.machinery')
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/import_/test_relative_imports.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Test relative imports (PEP 328)."""
from .. import util
from test.test_importlib import util
import unittest
import warnings

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/source/test_case_sensitivity.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Test case-sensitivity (PEP 235)."""
import sys

from .. import util
from test.test_importlib import util

importlib = util.import_importlib('importlib')
machinery = util.import_importlib('importlib.machinery')
Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/source/test_file_loader.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

importlib = util.import_importlib('importlib')
importlib_abc = util.import_importlib('importlib.abc')
Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_importlib/source/test_finder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .. import abc
from .. import util
from test.test_importlib import abc, util

machinery = util.import_importlib('importlib.machinery')

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/source/test_path_hook.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util

machinery = util.import_importlib('importlib.machinery')

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/source/test_source_encoding.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .. import util
from test.test_importlib import util

machinery = util.import_importlib('importlib.machinery')

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from unittest import mock
import warnings

from . import util as test_util
from test.test_importlib import util as test_util

init = test_util.import_importlib('importlib')
abc = test_util.import_importlib('importlib.abc')
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_api.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from . import util as test_util
from test.test_importlib import util as test_util

init = test_util.import_importlib('importlib')
util = test_util.import_importlib('importlib.util')
Expand Down
6 changes: 5 additions & 1 deletion Lib/test/test_importlib/test_compatibilty_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
wrap_spec,
)

from .resources import util
from test.test_importlib.resources import util


class CompatibilityFilesTests(unittest.TestCase):
Expand Down Expand Up @@ -100,3 +100,7 @@ def files(self):

def test_spec_path_joinpath(self):
self.assertIsInstance(self.files / 'a', CompatibilityFiles.OrphanPath)


if __name__ == '__main__':
unittest.main()
10 changes: 7 additions & 3 deletions Lib/test/test_importlib/test_contents.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest
from importlib import resources

from . import data01
from .resources import util
from test.test_importlib import data01
from test.test_importlib.resources import util


class ContentsTests:
Expand Down Expand Up @@ -38,6 +38,10 @@ class ContentsNamespaceTests(ContentsTests, unittest.TestCase):
}

def setUp(self):
from . import namespacedata01
from test.test_importlib import namespacedata01

self.data = namespacedata01


if __name__ == '__main__':
unittest.main()
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

from importlib import resources
from importlib.abc import Traversable
from . import data01
from .resources import util
from test.test_importlib import data01
from test.test_importlib.resources import util


class FilesTests:
Expand Down Expand Up @@ -37,7 +37,7 @@ class OpenZipTests(FilesTests, util.ZipSetup, unittest.TestCase):

class OpenNamespaceTests(FilesTests, unittest.TestCase):
def setUp(self):
from . import namespacedata01
from test.test_importlib import namespacedata01

self.data = namespacedata01

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_lazy.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import types
import unittest

from . import util as test_util
from test.test_importlib import util as test_util


class CollectInit:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_locks.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from . import util as test_util
from test.test_importlib import util as test_util

init = test_util.import_importlib('importlib')

Expand Down
8 changes: 6 additions & 2 deletions Lib/test/test_importlib/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
try:
import pyfakefs.fake_filesystem_unittest as ffs
except ImportError:
from .stubs import fake_filesystem_unittest as ffs
from test.test_importlib.stubs import fake_filesystem_unittest as ffs

from . import fixtures
from test.test_importlib import fixtures
from importlib.metadata import (
Distribution,
EntryPoint,
Expand Down Expand Up @@ -315,3 +315,7 @@ def test_packages_distributions_neither_toplevel_nor_files(self):
prefix=self.site_dir,
)
packages_distributions()


if __name__ == '__main__':
unittest.main()
6 changes: 5 additions & 1 deletion Lib/test/test_importlib/test_metadata_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import importlib
import contextlib

from . import fixtures
from test.test_importlib import fixtures
from importlib.metadata import (
Distribution,
PackageNotFoundError,
Expand Down Expand Up @@ -313,3 +313,7 @@ class InvalidateCache(unittest.TestCase):
def test_invalidate_cache(self):
# No externally observable behavior, but ensures test coverage...
importlib.invalidate_caches()


if __name__ == '__main__':
unittest.main()
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_open.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest

from importlib import resources
from . import data01
from .resources import util
from test.test_importlib import data01
from test.test_importlib.resources import util


class CommonBinaryTests(util.CommonTests, unittest.TestCase):
Expand Down Expand Up @@ -68,7 +68,7 @@ def setUp(self):

class OpenDiskNamespaceTests(OpenTests, unittest.TestCase):
def setUp(self):
from . import namespacedata01
from test.test_importlib import namespacedata01

self.data = namespacedata01

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_importlib/test_path.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import unittest

from importlib import resources
from . import data01
from .resources import util
from test.test_importlib import data01
from test.test_importlib.resources import util


class CommonTests(util.CommonTests, unittest.TestCase):
Expand Down
6 changes: 3 additions & 3 deletions Lib/test/test_importlib/test_read.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import unittest

from importlib import import_module, resources
from . import data01
from .resources import util
from test.test_importlib import data01
from test.test_importlib.resources import util


class CommonBinaryTests(util.CommonTests, unittest.TestCase):
Expand Down Expand Up @@ -66,7 +66,7 @@ def test_read_submodule_resource_by_name(self):

class ReadNamespaceTests(ReadTests, unittest.TestCase):
def setUp(self):
from . import namespacedata01
from test.test_importlib import namespacedata01

self.data = namespacedata01

Expand Down
5 changes: 2 additions & 3 deletions Lib/test/test_importlib/test_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
import uuid
import pathlib

from . import data01
from . import zipdata01, zipdata02
from .resources import util
from test.test_importlib import data01, zipdata01, zipdata02
from test.test_importlib.resources import util
from importlib import resources, import_module
from test.support import import_helper
from test.support.os_helper import unlink
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_spec.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from . import util as test_util
from test.test_importlib import util as test_util

init = test_util.import_importlib('importlib')
machinery = test_util.import_importlib('importlib.machinery')
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_importlib/test_util.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from . import util
from test.test_importlib import util

abc = util.import_importlib('importlib.abc')
init = util.import_importlib('importlib')
machinery = util.import_importlib('importlib.machinery')
Expand Down
8 changes: 5 additions & 3 deletions Lib/test/test_importlib/test_windows.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
from . import util as test_util
from test.test_importlib import util as test_util
machinery = test_util.import_importlib('importlib.machinery')

import os
import re
import sys
import unittest
import warnings
from test import support
from test.support import import_helper
from contextlib import contextmanager
from .util import temp_module
from test.test_importlib.util import temp_module

import_helper.import_module('winreg', required_on=['win'])
from winreg import (
Expand Down Expand Up @@ -178,3 +177,6 @@ def test_path_join(self):
self.check_join("C:", "C:", "")
self.check_join("//Server/Share\\", "//Server/Share/", "")
self.check_join("//Server/Share\\", "//Server/Share", "")

if __name__ == '__main__':
unittest.main()
5 changes: 4 additions & 1 deletion Lib/test/test_importlib/test_zip.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import sys
import unittest

from . import fixtures
from test.test_importlib import fixtures
from importlib.metadata import (
PackageNotFoundError,
distribution,
Expand Down Expand Up @@ -60,3 +60,6 @@ def test_files(self):
def test_normalized_name(self):
dist = distribution('example')
assert dist._normalized_name == 'example'

if __name__ == '__main__':
unittest.main()