Skip to content

[3.9] bpo-21987: Fix TarFile.getmember getting a dir with a trailing slash (GH-30283) #30738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 21, 2022

(cherry picked from commit cfadcc3)

Co-authored-by: andrei kulakov [email protected]

https://bugs.python.org/issue21987

@miss-islington
Copy link
Contributor Author

@akulakov and @serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@akulakov and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Member

@serhiy-storchaka: The change should be backported manually, tests fail on Python 3.9 with:

NameError: name 'os_helper' is not defined

@vstinner
Copy link
Member

@raghavthind2005 approved these changes 11 hours ago

@raghavthind2005: Did you look at test failures before approving the backport?

@serhiy-storchaka serhiy-storchaka merged commit 94d6434 into python:3.9 Jan 23, 2022
@miss-islington miss-islington deleted the backport-cfadcc3-3.9 branch January 23, 2022 17:54
@vstinner
Copy link
Member

Oh nice, it's a nice trick to use GitHub suggestion to modify a PR created by @miss-islington ;-)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants