Skip to content

bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ #30851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 24, 2022

https://bugs.python.org/issue46513

Automerge-Triggered-By: GH:tiran

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit ebd654724c6e3d0b528f1313b7654002eef40b52 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2022
@hroncok
Copy link
Contributor

hroncok commented Jan 25, 2022

@tiran tiran changed the title Test build without AC_C_CHAR_UNSIGNED bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ Jan 25, 2022
@tiran tiran marked this pull request as ready for review January 25, 2022 11:34
@tiran tiran added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 25, 2022
Copy link
Contributor

@hroncok hroncok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment on lines 8 to 9
/* This module currently does not work on systems where only unsigned
characters are available. Take it out of Setup. Sorry. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last part of the comment should be removed, it is confusing without the preprocessor guards. I'd consider just dropping the comment, a compiler where "signed char" is not signed should be considered broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was introduced by b6775db in 1994, just five years after the first ever C standard was published. Internet distribution was slow and software companies were rigid back then so no surprise compatibility with per vendor compiler quirks was a real deal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this outdated comment. audioop explicitly uses signed char and unsigned char. Maybe to avoid any risk of confusion, the C code should use int8_t and uint8_t.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is pining for the fjords.

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.10

@miss-islington miss-islington self-assigned this Jan 26, 2022
@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 26, 2022
@bedevere-bot
Copy link

GH-30914 is a backport of this pull request to the 3.10 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2022
tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 26, 2022
@bedevere-bot
Copy link

GH-30915 is a backport of this pull request to the 3.9 branch.

tiran added a commit that referenced this pull request Jan 26, 2022
tiran added a commit that referenced this pull request Jan 26, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request May 21, 2024
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants