bpo-46603: improve coverage of typing._strip_annotations
#31063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3355,6 +3355,15 @@ def barfoo4(x: BA3): ... | |||
| {"x": typing.Annotated[int | float, "const"]} | |||
| ) | |||
|
|
|||
| def test_get_type_hints_annotated_in_union(self): # bpo-46603 | |||
| def with_union(x: int | list[Annotated[str, 'meta']]): ... | |||
There was a problem hiding this comment.
Are all the other paths covered already? This test doesn't seem to cover the _GenericAlias branch in _strip_annotations.
There was a problem hiding this comment.
Yes, other branches are reported to be covered by other tests in test_typing somewhere.
JelleZijlstra
added
needs backport to 3.9
JelleZijlstra
approved these changes
Feb 17, 2022
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2022
…31063) (cherry picked from commit 25c0b9d) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2022
…31063) (cherry picked from commit 25c0b9d) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-31423 is a backport of this pull request to the 3.10 branch. |
|
GH-31424 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 19, 2022
(cherry picked from commit 25c0b9d) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not covered at all, proof:
It took me some time to understand how can I possibly reach it. After adding this test, we now cover this path. Proof:
https://bugs.python.org/issue46603