Skip to content

bpo-45975: Use walrus operator for while loops in IDLE #31083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

bpo-45975: Use walrus operator for while loops in IDLE #31083

merged 1 commit into from
Feb 3, 2022

Conversation

nickdrozd
Copy link
Contributor

@nickdrozd nickdrozd commented Feb 2, 2022 •
edited by bedevere-bot
Loading

By request of @terryjreedy, these are just the IDLE changes from #29347.

https://bugs.python.org/issue45975

@nickdrozd nickdrozd mentioned this pull request Feb 2, 2022
Merged
@zware zware added the skip news label Feb 2, 2022
@terryjreedy terryjreedy added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 3, 2022
@terryjreedy terryjreedy merged commit 51a95be into python:main Feb 3, 2022
@miss-islington
Copy link
Contributor

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2022
@nickdrozd @miss-islington
bpo-45975: Use walrus operator for some idlelib while loops (pythonGH…
f8e1c13 
…-31083)

(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @nickdrozd and @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 3, 2022
@bedevere-bot
Copy link

GH-31091 is a backport of this pull request to the 3.10 branch.

@terryjreedy terryjreedy added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Feb 3, 2022
@miss-islington
Copy link
Contributor

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @nickdrozd and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

miss-islington added a commit that referenced this pull request Feb 3, 2022
@miss-islington @nickdrozd
bpo-45975: Use walrus operator for some idlelib while loops (GH-31083)
2ddc278 
(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <[email protected]>
@terryjreedy
Copy link
Member

I reviewed the changes, ran test_idle, and manually exercised features that should run the affected code.
The merge issue is that the sideport changes are to sections adding in 3.10.

terryjreedy added a commit that referenced this pull request Feb 3, 2022
@terryjreedy
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (GH…
fafd2da 
…-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
@nickdrozd nickdrozd deleted the idle-walrus branch February 3, 2022 03:58
@nickdrozd
Copy link
Contributor Author

Thanks for reviewing, @terryjreedy!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@terryjreedy @hello-adam
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (py…
ab38b43 
…thonGH-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
@nickdrozd nickdrozd mannequin mentioned this pull request Dec 6, 2022
Closed
@hugovk hugovk removed the needs backport to 3.9 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

@terryjreedy terryjreedy

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nickdrozd @miss-islington @bedevere-bot @terryjreedy @hugovk @zware @the-knights-who-say-ni