Skip to content

bpo-46670: Remove unused macros in ceval.c #31196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

bpo-46670: Remove unused macros in ceval.c #31196

merged 1 commit into from
Feb 7, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 7, 2022 •
edited by bedevere-bot
Loading

Remove CHECKEXC() and EXT_POP() macros.

https://bugs.python.org/issue46670

@vstinner
bpo-46670: Remove unused macros in ceval.c
602ebaa 
Remove CHECKEXC() and EXT_POP() macros.
@vstinner vstinner requested a review from markshannon as a code owner February 7, 2022 14:14
@markshannon markshannon merged commit 4b603f6 into python:main Feb 7, 2022
@markshannon
Copy link
Member

Thanks

@vstinner vstinner deleted the unused_macros_ceval branch February 7, 2022 15:19
@vstinner
Copy link
Member Author

vstinner commented Feb 7, 2022

@markshannon: There is also FOURTH(): `PEEK(-4) is now preferred. And another one that I forgot (oops). But I was too shy to remove these ones :-D They can be removed later.

@vstinner
Copy link
Member Author

vstinner commented Feb 7, 2022

Thanks

The CHECKEXC macro was a hack, it's good that it's gone :-)

@vstinner vstinner mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @markshannon @the-knights-who-say-ni @bedevere-bot