Skip to content

[3.10] bpo-46685: cover TypeError of ForwardRef(1) in test_typing (GH-31223) #31229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

[3.10] bpo-46685: cover TypeError of ForwardRef(1) in test_typing (GH-31223) #31229

merged 1 commit into from
Feb 9, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 9, 2022 •
edited by bedevere-bot
Loading

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev [email protected]

https://bugs.python.org/issue46685

@sobolevn @miss-islington
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (pyt…
afd1f05 
…honGH-31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Feb 9, 2022
@bedevere-bot bedevere-bot mentioned this pull request Feb 9, 2022
Merged
@miss-islington
Copy link
Contributor Author

@brettcannon and @zware: Status check is done, and it's a success ✅ .

3 similar comments
@miss-islington
Copy link
Contributor Author

@brettcannon and @zware: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@brettcannon and @zware: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@brettcannon and @zware: Status check is done, and it's a success ✅ .

corona10
corona10 reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn Do we need to backport this PR?

@sobolevn
Copy link
Member

sobolevn commented Feb 9, 2022 •
edited
Loading

From my experience, other core-devs do backport similar PRs.

This line exists on both 3.9 and 3.10:

Thanks for your review and merge! 👍

corona10
corona10 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn
In my experience, most backported test PRs are caused by the same regression.

@miss-islington miss-islington merged commit d29bbc2 into python:3.10 Feb 9, 2022
@miss-islington miss-islington deleted the backport-d2d1d49-3.10 branch February 9, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @sobolevn @corona10 @the-knights-who-say-ni @bedevere-bot